Add playbook to set SMT on worker nodes #54
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishen-v The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
|
||
| - name: Restart kubelet to update the node's capacity at the cluster level | ||
| shell: systemctl restart kubelet | ||
| when: node_type == "worker" |
There was a problem hiding this comment.
may be we can remove node_type once we set the hosts properly in the calling yaml file with hosts type set!
There was a problem hiding this comment.
Hey @mkumatag, I've made the changes generic to allow an option to set the SMT for a node regardless of its kind.
kishen-v
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
kishen-v
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
|
||
| - name: Restart kubelet to update the node's capacity at the cluster level | ||
| shell: systemctl restart kubelet | ||
| when: inventory_hostname in groups[item.key] |
There was a problem hiding this comment.
item usually will be applicable when loop in place, not sure what is behaviour here
There was a problem hiding this comment.
Hey @mkumatag, the when: inventory_hostname in groups[item.key] condition was added to prevent the command from running against all hosts, as the playbook has it defined..
Without this check, the last SMT value to be applied across was being set across all nodes, regardless of the previously set configuration..
There was a problem hiding this comment.
Update: Removed the looping as there are related files for masters/workers under group_vars.. The individual SMT levels are set in the respective files.
| - role: reboot-sequentially | ||
| - reboot-sequentially | ||
|
|
||
| - name: Set desired SMT levels on nodes |
There was a problem hiding this comment.
Necessary to set the SMT levels while patching, as the previous SMT configurations do not persist on a node restart.
3 participants
This PR introduces an ansible role to set SMT while setting up the build cluster.
The relevant documentation surrounding this topic will be submitted to k8s.io/infra, along the steps involved while setting up the build cluster as a follow-up task.